Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/esm modules #287

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Fix/esm modules #287

merged 1 commit into from
Feb 3, 2021

Conversation

joshuaellis
Copy link
Member

Why

resolves #284

What

Check for typeof window to be undefined (which will be true in SSR) and return Buffer if true. atob if false

Checklist

  • Ready to be merged

@vercel
Copy link

vercel bot commented Feb 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/drei/8l13y7itf
✅ Preview: https://drei-git-fix-esm-modules.pmndrs.vercel.app

@joshuaellis joshuaellis changed the base branch from master to beta February 3, 2021 18:54
@joshuaellis joshuaellis merged commit e6d3a5c into beta Feb 3, 2021
@joshuaellis joshuaellis deleted the fix/esm-modules branch February 3, 2021 18:55
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 3, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 24cd918:

Sandbox Source
magical-chaplygin-uiuq3 Configuration
drei reflector Configuration
arc-x-pmndrs-colors Configuration

@github-actions
Copy link

github-actions bot commented Feb 3, 2021

🎉 This PR is included in version 3.3.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released on @beta released in beta for review label Feb 3, 2021
@github-actions
Copy link

github-actions bot commented Feb 3, 2021

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @beta released in beta for review released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global not defined in ESM bundles.
1 participant