chore: fix ide complaints #2122
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 38a6702:
|
| @@ -11,6 +11,7 @@ | |||
| "exactOptionalPropertyTypes": true, | |||
| "baseUrl": ".", | |||
| "skipLibCheck": true, | |||
| "noEmit": true, | |||
There was a problem hiding this comment.
Do we need this even if we have --noEmit option?
There was a problem hiding this comment.
sorry i misunderstood, yes we need it because allowImportingTsExtensions is only allowed when --noEmit or --emitDeclarationOnly is enabled, since these import paths would not be resolvable at runtime in JavaScript output files.
https://www.typescriptlang.org/tsconfig#allowImportingTsExtensions
There was a problem hiding this comment.
We used to have --noEmit in package.json and no "noEmit" in tsconfig.json. Does it cause any errors with this PR's change?
I mean I'm aware of https://www.typescriptlang.org/tsconfig#allowImportingTsExtensions and it's working before this PR, so I'm confused.
There was a problem hiding this comment.
it'ok, we are bundling with rollup instead of tsc.
if you remove the --noEmit option in the pretest script, you will be able to see the complaint in the console.
There was a problem hiding this comment.
Yeah, I know. I'm fine with having "noEmit" in tsconfig.json, but in that case remove --noEmit from pretest script to avoid duplication. But, if --noEmit works without adding "noEmit" in tsconfig.json, it keep the original idea, so it seems better.
There was a problem hiding this comment.
VSCode(tsserver) will show an error in the tsconfig.json
There was a problem hiding this comment.
Alright! thanks for the clarification!
There was a problem hiding this comment.
The change looks good.
Can you also open the same PR in the two repos? https://github.com/pmndrs/zustand and https://github.com/pmndrs/valtio
|
there is a flaky test case :( |
Yeah... Maybe using user-event would help. |
Hmm, Feel free to dig into it! |
Related Issues or Discussions
Summary
Check List
yarn run prettierfor formatting code and docs