✅ test: add unit test for atomWithReset utility #2753
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| vi.mock('jotai/vanilla', async (importOriginal) => { | ||
| const actual = await importOriginal<typeof import('jotai/vanilla')>() | ||
| return { | ||
| ...actual, | ||
| atom: vi.fn(actual.atom), | ||
| } | ||
| }) |
There was a problem hiding this comment.
we haven't don this before, but it looks nice.
There was a problem hiding this comment.
I have remove it, it is useless in this case.
| it('should reset to initial value using RESET', () => { | ||
| const set = vi.fn() | ||
| const get = vi.fn(() => 20) | ||
| testAtom.write(get, set, RESET) |
There was a problem hiding this comment.
write is an implementation detail, and we would like to test with store api.
can you try this?
const store = createStore();
store.set(testAtom, RESET);There was a problem hiding this comment.
@dai-shi I have already added the test code for using createStore and kept the previous test code, as it can isolate the dependency on createStore.
There was a problem hiding this comment.
It's testing the internal behavior, which isn't guaranteed to work as it is now (it's likely though), so let's remove it.
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/85KHDAFAN |
See documentations for usage instructions.
| it('should create an atom with initial value', () => { | ||
| const { init } = testAtom | ||
| expect(init).toBe(initialValue) | ||
| }) |
There was a problem hiding this comment.
This is testing the internal behavior. While it's correct, let's remove from the atomWithReset test.
| it('should reset to initial value using RESET', () => { | ||
| const set = vi.fn() | ||
| const get = vi.fn(() => 20) | ||
| testAtom.write(get, set, RESET) |
There was a problem hiding this comment.
It's testing the internal behavior, which isn't guaranteed to work as it is now (it's likely though), so let's remove it.
Summary
Add unit test for src/vanilla/utils/atomWithReset.ts
Check List
pnpm run prettierfor formatting code and docs