fix: unwrap synchronously returns awaited values of resolved promise atoms #2880
+100
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/7MCQHW67N |
See documentations for usage instructions.
dmaskasky
force-pushed
the
sync-unwrap
branch
from
cf3a912 to
0913ff8
Compare
dmaskasky
commented
Dec 19, 2024
| expect(store.get(syncAtom)).toBe(3) | ||
| }) | ||
|
|
||
| it('should unwrap to a fulfilled value of an already resolved async atom', async () => { | ||
| const store = createStore() | ||
| const asyncAtom = atom(Promise.resolve('concrete')) | ||
|
|
||
| expect(await store.get(asyncAtom)).toEqual('concrete') | ||
| expect(store.get(unwrap(asyncAtom))).toEqual(undefined) |
There was a problem hiding this comment.
This is the change in behavior.
dmaskasky
force-pushed
the
sync-unwrap
branch
3 times, most recently
from
90ac5e5 to
577ef67
Compare
dmaskasky
force-pushed
the
sync-unwrap
branch
from
577ef67 to
5b14751
Compare
dmaskasky
force-pushed
the
sync-unwrap
branch
from
5b14751 to
48cff68
Compare
dmaskasky
force-pushed
the
sync-unwrap
branch
from
48cff68 to
4efe200
Compare
|
Ohhhhh, my big apologies. This is not acceptable, but let's see if we have other solutions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Bug Reports or Discussions
#2877
Summary
Synchronously return atom values whose promises have already resolved.
Check List
pnpm run prettierfor formatting code and docs