-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated docs and website styles #1017
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
Size Change: 0 B Total Size: 13.6 kB ℹ️ View Unchanged
|
@dai-shi - not able to see the vercel deployment error logs - can you paste the error in here when you get a chance? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small requests
docs/resources/libraries.mdx
Outdated
|
||
<br /> | ||
|
||
- [valtio-reactive](https://github.com/valtiojs/valtio-reactive) - Valtio-reactive makes valtio a reactive library. It is an improvement on the derive function. It allows you to create computed values that are reactive to changes in their dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list is ordered alphabetically.
docs/api/utils/derive.mdx
Outdated
<blockquote className="note"> | ||
ℹ️ Note | ||
|
||
There is a new library called [valtio-reactive](https://github.com/valtiojs/valtio-reactive) that is a drop-in replacement for `derive` and provides a more powerful API. It is recommended to use that library instead. | ||
|
||
</blockquote> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a drop-in replacement. It's purpose and implementation design is a bit different.
watch
will be deprecated in favor of valtio-reactive
.
So, I'd suggest to remove this section for now.
docs/resources/libraries.mdx
Outdated
|
||
<br /> | ||
|
||
- [valtio-reactive](https://github.com/valtiojs/valtio-reactive) - Valtio-reactive makes valtio a reactive library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, it's not ordered alphabetically.
Related Bug Reports or Discussions
N/A
Fixes #
N/A
Summary
Updated some docs and styles for the website to make the two more consistent
Check List
pnpm run prettier
for formatting code and docs