-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed examples to work on stackblitz #1018
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Size Change: 0 B Total Size: 13.6 kB ℹ️ View Unchanged
|
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks tons.
Related Bug Reports or Discussions
#1012
Fixes #
#1012
Summary
Fixed the examples to work on stackblitz. Changed the syntax highlighting to use lowlight instead of prism so there wasn't a peer conflict for react (prism doesn't support above 16 it seems).
Working examples (while branch exists)
https://stackblitz.com/github/pmndrs/valtio/tree/1012/examples/counter?file=package.json
https://stackblitz.com/github/pmndrs/valtio/tree/1012/examples/editor-proxyWithHistory?file=package.json
https://stackblitz.com/github/pmndrs/valtio/tree/1012/examples/photo-booth-vanillajs?file=package.json
https://stackblitz.com/github/pmndrs/valtio/tree/1012/examples/todo?file=package.json
https://stackblitz.com/github/pmndrs/valtio/tree/1012/examples/todo-with-proxyMap?file=package.json
Check List
pnpm run prettier
for formatting code and docs