Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(.github/workflows): improve workflow with removing duplicated configs #1024

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Dec 19, 2024

Summary

Check List

  • pnpm run prettier for formatting code and docs

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valtio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 1:07pm

Copy link

codesandbox-ci bot commented Dec 19, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Dec 19, 2024

Open in Stackblitz

More templates

npm i https://pkg.pr.new/valtio@1024

commit: dca2cc2

@sukvvon sukvvon force-pushed the chore/add-details-in-cr-action branch from 2978fb2 to 6010a0f Compare December 19, 2024 12:40
@sukvvon sukvvon changed the title chore(.github/workflows/cr.yml): improve workflow with pnpm dlx and caching chore(.github/workflows): improve workflow with removing duplicated configs Dec 19, 2024
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use pnpm dlx like others?

@sukvvon
Copy link
Contributor Author

sukvvon commented Dec 19, 2024

@dai-shi Wait a second please i found that i missed

@sukvvon sukvvon force-pushed the chore/add-details-in-cr-action branch from 7c4d16c to 889b72f Compare December 19, 2024 13:06
@sukvvon
Copy link
Contributor Author

sukvvon commented Dec 19, 2024

@dai-shi Done!

@dai-shi dai-shi merged commit 83097ef into pmndrs:main Dec 19, 2024
28 checks passed
@sukvvon sukvvon deleted the chore/add-details-in-cr-action branch December 19, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants