Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: example/demo #2585

Merged
merged 2 commits into from
Jun 6, 2024
Merged

update: example/demo #2585

merged 2 commits into from
Jun 6, 2024

Conversation

sunil-sharma-999
Copy link
Contributor

Summary

  • fix eslint config and lint issues
  • fix react key issue
  • remove children passed as props
  • remove unused variables and imports
  • "encodings_fragment" is deprecated, replaced it with "colorspace_fragment"

Check List

  • pnpm run prettier for formatting code and docs
  • pnpm run test for test

- fix eslint config and lint issues
- fix react key issue
- remove children passed as props
- remove unused variables and imports
- "encodings_fragment" is deprecated, replaced it with "colorspace_fragment"
Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 0:20am

Copy link

codesandbox-ci bot commented Jun 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall.

Would anyone like to give another review?

examples/demo/package.json Outdated Show resolved Hide resolved
Copy link

codesandbox-ci bot commented Jun 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi
Copy link
Member

dai-shi commented Jun 6, 2024

Would anyone like to give another review?

No one...

@dbritto-dev
Copy link
Collaborator

@sunil-sharma-999 @dai-shi LGTM

@dai-shi dai-shi merged commit 3b90e1c into pmndrs:main Jun 6, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants