Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shallow): iterable-like insensitive keys order comparison (alternate implementation) #2821

Merged
merged 6 commits into from
Oct 30, 2024

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Oct 27, 2024

Using the same tests in #2816.

Copy link

vercel bot commented Oct 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 4:13am

Copy link

codesandbox-ci bot commented Oct 27, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

github-actions bot commented Oct 27, 2024

Size Change: -90 B (-0.75%)

Total Size: 11.9 kB

Filename Size Change
./dist/esm/vanilla/shallow.mjs 523 B -44 B (-7.76%)
./dist/vanilla/shallow.js 535 B -46 B (-7.92%)
ℹ️ View Unchanged
Filename Size
./dist/esm/index.mjs 64 B
./dist/esm/middleware.mjs 3.56 kB
./dist/esm/middleware/immer.mjs 210 B
./dist/esm/react.mjs 320 B
./dist/esm/react/shallow.mjs 193 B
./dist/esm/shallow.mjs 82 B
./dist/esm/traditional.mjs 411 B
./dist/esm/vanilla.mjs 403 B
./dist/index.js 244 B
./dist/middleware.js 3.56 kB
./dist/middleware/immer.js 229 B
./dist/react.js 336 B
./dist/react/shallow.js 208 B
./dist/shallow.js 189 B
./dist/traditional.js 423 B
./dist/vanilla.js 416 B

compressed-size-action

@dai-shi
Copy link
Member Author

dai-shi commented Oct 28, 2024

@dbritto-dev How do you like this one?

@dbritto-dev
Copy link
Collaborator

@dai-shi way better, I like this one

@dai-shi dai-shi changed the title alternate implementation for shallow fix(shallow): iterable-like insensitive keys order comparison (alternate implementation) Oct 29, 2024
@dai-shi dai-shi added this to the v5.0.1 milestone Oct 30, 2024
@dai-shi dai-shi merged commit 9525f92 into main Oct 30, 2024
24 checks passed
@dai-shi dai-shi deleted the update-shallow-2 branch October 30, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants