making originating origin header optional in unpack request functions #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shawn-hurley
commented
Mar 8, 2018
shawn-hurley
commented
- platforms are not guaranteed to send this header
- logging error so that if a user is expecting the header they can still see what is wrong
* platforms are not guaranteed to send this header.
lilic
reviewed
Mar 8, 2018
| if err != nil { | ||
| return nil, err | ||
| glog.Infof("Unable to retrieve originating identity - %v", err) |
There was a problem hiding this comment.
This just seems to sort of duplicate the error msg, I would just log the error msg instead, see:
I0308 14:54:32.912222 1 apisurface.go:126] Unable to retrieve originating identity - unable to find originating identity
There was a problem hiding this comment.
retrieveOriginatingIdentity can return 2 different errors, I don't see a problem with the log. It is duplicated under one instance, but not another. And if someone ever changes the method to return a different error it might be harder to track down. So the duplicate message doesn't bother me.
There was a problem hiding this comment.
@jmrodri Fair point, better to duplicate then to having to track down where the error originated.
|
LGTM |
|
Thank you for this fix! 💯 |
jboyd01
pushed a commit
to jboyd01/osb-broker-lib
that referenced
this pull request
Apr 17, 2018
Rename to osb-starter-pack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.