Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding library response types #27

Merged
merged 3 commits into from
Mar 14, 2018
Merged

adding library response types #27

merged 3 commits into from
Mar 14, 2018

Conversation

shawn-hurley
Copy link
Contributor

This is in regards to #13.

This creates the new types of the responses that the broker.Interface will eventually use.

cc @pmorie @jmrodri

@jmrodri
Copy link
Contributor

jmrodri commented Mar 9, 2018

LGTM, matches what was discussed in that issue.

pmorie
pmorie reviewed Mar 10, 2018
View reviewed changes
Copy link
Owner

@pmorie pmorie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you integrate these types into the interface?

pkg/broker/types.go Outdated

// AlreadyReceived is used to determine if the request was a duplicate
// or not. should not be sent back in the respone.
AlreadyReceived bool `json:"-"`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take out this field (and the binding) one and let's add in another issue

@shawn-hurley
set new types in interface
49963b0 
* removing new field for follow on PR.
@shawn-hurley
adding provision response types to interface
04bcc52 
* fixing test cases
@pmorie pmorie requested a review from lilic March 13, 2018 20:19
@pmorie
Copy link
Owner

pmorie commented Mar 13, 2018

LGTM

1 similar comment
@jmrodri
Copy link
Contributor

jmrodri commented Mar 14, 2018

LGTM

@jmrodri
Copy link
Contributor

jmrodri commented Mar 14, 2018

Is this waiting for anything? Can one of you merge? @pmorie @carolynvs @lilic

@carolynvs
Copy link
Collaborator

LGTM 3 - merging

@carolynvs carolynvs merged commit cd526f5 into pmorie:master Mar 14, 2018
@lilic
Copy link
Collaborator

lilic commented Mar 14, 2018

I would really like to have some kind of a "breaking change" in a description, or a label in the PR. So we can easily add to the release notes, and then when we bump versions in our brokers or in the osb-starter-pack we know what to look out for. :) WDYT? @carolynvs @pmorie @shawn-hurley

@shawn-hurley
Copy link
Contributor Author

I think that would be useful for all downstream users of the library. I think that it should probably be on the PR in my opinion.

@carolynvs
Copy link
Collaborator

Agreed! We would all use the hint and the best place for it is in the PR title or main comment.

@lilic lilic mentioned this pull request Mar 14, 2018
Open
@jmrodri jmrodri mentioned this pull request Mar 25, 2018
Closed
@n3wscott n3wscott mentioned this pull request Mar 25, 2018
Closed
jboyd01 pushed a commit to jboyd01/osb-broker-lib that referenced this pull request Apr 17, 2018
@pmorie
Merge pull request pmorie#27 from pmorie/openshift-template
69931d3 
Add openshift template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmorie pmorie pmorie left review comments

@lilic lilic Awaiting requested review from lilic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shawn-hurley @jmrodri @pmorie @carolynvs @lilic