Allow to register APISurface endpoints and handlers on an external HTTP server #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
shawn-hurley
suggested changes
Mar 23, 2018
|
@shawn-hurley right, I will add an unit-test. |
clamoriniere1A
force-pushed
the
feature/externallHTTPServer
branch
from
d45c56d to
291ba7e
Compare
Currently, it wasn't possible to register the Broker APISurface handler on an external HTTP server, since the registration was included in the server.New() method that instantiates also the server.Server. This commit is splitting the current server.New(...) method in two in order to have a specific method for APISurface handler registration: server.registerHTTPHandler(...). An additional Public method NewHTTPHandler(...) is added in order to allow a user to register on an external HTTP server the Broker API endpoints.
|
@shawn-hurley unit-test added |
shawn-hurley
approved these changes
Mar 25, 2018
|
Thanks for the patch @clamoriniere1A |
jboyd01
pushed a commit
to jboyd01/osb-broker-lib
that referenced
this pull request
Apr 17, 2018
Add ability to update the service instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is implementing the proposal done in the issue: #32