fix: replace yaml dash with underscore to prevent build error

[henrikvilhelmberglund]

This PR changes frontmatter dash characters excalidraw-plugin to an underscore excalidraw_plugin to fix building issues if you're importing a .md file with YAML that's not JS compatible. (there may be other characters that are also not allowed but in my case dash was enough)

I think you don't want YAML stuff with dashes anyway in a mdsvex context so this shouldn't matter too much. I would have liked to use replaceAll() but it is only available in ES2021 or higher.

I have no idea how to make a changeset right now, will take a look later.

fixes #544

[changeset-bot]

🦋 Changeset detected

Latest commit: 3d717fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
mdsvex	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

commit: 8c14e09

mdsvex

pnpm add https://pkg.pr.new/pngwn/MDsveX/mdsvex@545

pfm-parse

pnpm add https://pkg.pr.new/pngwn/MDsveX/pfm-parse@545

svast

pnpm add https://pkg.pr.new/pngwn/MDsveX/svast@545

svast-stringify

pnpm add https://pkg.pr.new/pngwn/MDsveX/svast-stringify@545

svast-utils

pnpm add https://pkg.pr.new/pngwn/MDsveX/svast-utils@545

svelte-parse

pnpm add https://pkg.pr.new/pngwn/MDsveX/svelte-parse@545

Open in Stackblitz

[henrikvilhelmberglund]

I forgot this even existed. 🤯

lint detected a million issues for me so I only did it on the file I changed, hopefully it works.

[pngwn]

Hey. Yea sorry. The reason I haven't merged it yet is that I think it would be a breaking change.

[henrikvilhelmberglund]

It could be but the previous behavior was that if you had metadata with dashes in it the build would just fail. Maybe things have changed though, not even sure that this is needed anymore, but it should be easy to test with for example the excalidraw-plugin.