Feature: Adding bundle for ProbNum2025 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 13, 2023 11:45
pnkraemer
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Great - I am looking forward to this!
Could you also add corresponding test-cases for the bundles, figsizes, fonts, and fontsizes? Concrete instructions should be in the online documentation. If you can't find them, let me know and I will help.
I left two comments (respectively three, but one is a duplicate) in the diff. I am wondering what you think about those.
|
Sorry that I missed the test cases. And I thought I had read the docs! Well, they are in now. |
pnkraemer
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: style file for ProbNum
This PR adds the bundles, figsizes, fonts, and fontsizes for ProbNum 2025.
The numbers are based on the style file. Note: That style isn't yet published in the CfP, as I am actively developing it. My goal is in fact to include a link to the tueplots bundle provided by this PR in the style file, and explicitly ask submitting authors to use the bundle. To make this possible I am first submitting this PR, and will then subsequently publish the style file.
Minor changes may be needed in the future, as the style file is yet to be sent out for feedback.