CMake build improvements + some extra #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to newever versions
rebuilds are avoided when the libraries are not updated/changes -> improves rebuild time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid rebuilding all packages with every rebuild. Only UKFtracrography module files will be recompiled on the build command. So, on a single core, the rebuild time is reduced from an hour to a few minutes (on my old laptop). My idea was to improve the maintainability of the repository and improve bug fixes time. In case external libraries have to be rebuilt, one can always pass the FORCE_EXTERNAL_BUILDS option as ON.
Additionally:
I think it can be merged after #143 with some edits (inserts to the different lines mostly).
This PR was tested on GCC and MSVC.