Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary kindKey Field in CrFwInRepKindDesc_t Structure #75

Closed
pasetti opened this issue Sep 22, 2017 · 2 comments
Closed

Unnecessary kindKey Field in CrFwInRepKindDesc_t Structure #75

pasetti opened this issue Sep 22, 2017 · 2 comments
Assignees

Comments

@pasetti
Copy link
Contributor

pasetti commented Sep 22, 2017

As far as I can tell, filed kindKey in the CrFwInRepKindDesc_t Structure is unused and unnecessary (the "kind keys" for incoming reports are held in array inRepKindKey in the InFactory module). This field is currently initialized to zero in the InFactoryUserPar.

I need to double-check my findings and then I should remove the unnecessary field.

@pasetti pasetti self-assigned this Sep 22, 2017
@pasetti
Copy link
Contributor Author

pasetti commented May 16, 2018

I have removed field kindKey in the CrFwInRepKindDesc_t Structure in CrFwConstants.h. I have also updated the initialization of this data structure in the InFactoryUserPar in the TestSuite.

I have checked the InFactoryUserPar files in the three applications in cordetfw-examples but they did not include the definition of this parameter.

The only remaining change is to remove kindKey from the generator of the CORDET Editor. The change must be done in function gen_cr_fw_in_factory_user_par of file gen_cfw.py.

@pasetti
Copy link
Contributor Author

pasetti commented May 16, 2018

The change in the CORDET Editor generator ( function gen_cr_fw_in_factory_user_par of file gen_cfw.p) has been done.

@pasetti pasetti closed this as completed May 16, 2018
pasetti added a commit that referenced this issue May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant