Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate property for teams tab list #5900

Closed
milanholemans opened this issue Mar 9, 2024 · 5 comments
Closed

Remove duplicate property for teams tab list #5900

milanholemans opened this issue Mar 9, 2024 · 5 comments

Comments

@milanholemans
Copy link
Contributor

For command teams tab list(https://pnp.github.io/cli-microsoft365/cmd/teams/tab/tab-list), we introduce a duplicate property called teamsAppTabId at the root of the result.
Duplicate data is not useful at all, so let's get rid of it.

const items = await odata.getAllItems<TeamsTab>(endpoint);
items.forEach(i => {
(i as any).teamsAppTabId = i.teamsApp!.id;
});

@waldekmastykarz
Copy link
Member

Wasn't the purpose of this property to be displayed in text/csv/md output where we can't show nested objects? If we remove the top-level property, it'll be gone from those output modes, and I think it's something that you'd want to have readily available when working with tabs.

@milanholemans
Copy link
Contributor Author

Yes, true. But in that case, we can just remove it for the json output and just include it for the others. However, I noticed that cli.shouldTrimOutput, the function that was made for this doesn't specify these outputs anymore.

@Adam-it
Copy link
Contributor

Adam-it commented Jul 7, 2024

Since we have v8 branch we may now start working on it!
Let's get this 🚢
and Let's put CLI to the 🚀🌙

@SmitaNachan
Copy link
Contributor

Can I work on it?

@Adam-it
Copy link
Contributor

Adam-it commented Jul 7, 2024

Can I work on it?

All yours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants