Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: reference entra m365group set by display name #6146

Closed
2 tasks
milanholemans opened this issue Jul 13, 2024 · 4 comments
Closed
2 tasks

Enhancement: reference entra m365group set by display name #6146

milanholemans opened this issue Jul 13, 2024 · 4 comments
Assignees
@MathijsVerbeeck
Labels
breaking change enhancement work in progress
Milestone
v10

Comments

@milanholemans
Copy link
Contributor

Currently when using the entra m365group set command, you can only specify the group by id. To be a bit more consistent with other commands, let's ensure that a group can also be specified by display name. Since there is already an option called displayName, we'll have to rename this option to newDisplayName.

Option to add:

Option Description
-n, displayname [displayName] Display name of the group.

Tasks:

  • Rename displayName to newDisplayName. Let's remove short -n as well.
  • Add new option displayName with short -n.
@milanholemans milanholemans added enhancement breaking change needs peer review Needs second pair of eyes to review the spec or PR labels Jul 13, 2024
@milanholemans milanholemans added this to the v9 milestone Jul 13, 2024
@Adam-it
Copy link
Contributor

Adam-it commented Jul 15, 2024

LGTM 👍

@Adam-it Adam-it added help wanted and removed needs peer review Needs second pair of eyes to review the spec or PR labels Jul 15, 2024
@ktskumar
Copy link
Contributor

ktskumar commented Aug 7, 2024

May I work on this?

@milanholemans
Copy link
Contributor Author

@ktskumar did you find some time to create a PR for this issue? We are trying to prioritize V10 PRs for our next major release.

@milanholemans
Copy link
Contributor Author

Opening it back up again due to the lack of response and the need to get this merged ASAP.

@MathijsVerbeeck MathijsVerbeeck self-assigned this Sep 21, 2024
MathijsVerbeeck added a commit to MathijsVerbeeck/cli-microsoft365 that referenced this issue Sep 21, 2024
@MathijsVerbeeck
Enhance entra m365group set. Closes pnp#6146
fe311c1
MathijsVerbeeck added a commit to MathijsVerbeeck/cli-microsoft365 that referenced this issue Sep 21, 2024
@MathijsVerbeeck
Enhance entra m365group set. Closes pnp#6146
5a46d6d
@MathijsVerbeeck MathijsVerbeeck mentioned this issue Sep 21, 2024
Closed
@MathijsVerbeeck MathijsVerbeeck linked a pull request Sep 21, 2024 that will close this issue
Enhance entra m365group set. Closes #6146 #6376
Closed
milanholemans pushed a commit that referenced this issue Sep 21, 2024
@MathijsVerbeeck @milanholemans
Enhances 'entra m365group set' with displayName. Closes #6146
da6c933
MathijsVerbeeck added a commit that referenced this issue Sep 24, 2024
@MathijsVerbeeck
Enhances 'entra m365group set' with displayName. Closes #6146
7404ed1
Adam-it pushed a commit that referenced this issue Sep 27, 2024
@MathijsVerbeeck @Adam-it
Enhances 'entra m365group set' with displayName. Closes #6146
e952949
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MathijsVerbeeck MathijsVerbeeck

Labels
breaking change enhancement work in progress
Projects
None yet
Milestone
v10
Development

Successfully merging a pull request may close this issue.

Enhance entra m365group set. Closes #6146 MathijsVerbeeck/cli-microsoft365
4 participants
@MathijsVerbeeck @milanholemans @ktskumar @Adam-it