Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure output for list commands #6288

Closed
16 tasks done
milanholemans opened this issue Aug 30, 2024 · 2 comments
Closed
16 tasks done

Ensure output for list commands #6288

milanholemans opened this issue Aug 30, 2024 · 2 comments
Assignees
@MathijsVerbeeck
Labels
breaking change work in progress
Milestone
v10

Comments

@milanholemans
Copy link
Contributor

milanholemans commented Aug 30, 2024 •
edited
Loading

Noticed that the command spo app instance list returns no output when there are no apps installed on a site. A list command should always give an output. If nothing is found, an empty list should be returned.
This is just one example of a command that should be updated. I saw the same behavior for:

  • entra oauth2grant list
  • flow environment list
  • pa app list
  • pa connector list
  • pa environment list
  • pp environment list
  • spo app instance list
  • spo app list
  • spo feature list
  • spo list webhook list
  • spo listitem attachment list
  • spo page list
  • spo page template list
  • spo sitescript list
  • spo theme list
  • spo web clientsidewebpart list
@milanholemans milanholemans added this to the v9 milestone Aug 30, 2024
@milanholemans milanholemans changed the title Ensure output for spo app instance list Ensure output for spo app commands Aug 30, 2024
@milanholemans milanholemans changed the title Ensure output for spo app commands Ensure output for list commands Sep 1, 2024
This was referenced Sep 1, 2024
Closed
Closed
@MathijsVerbeeck MathijsVerbeeck self-assigned this Sep 17, 2024
@MathijsVerbeeck
Copy link
Contributor

@milanholemans I have tested this with every command, and you are correct, but when executing spo theme list without having themes I am getting an output however 😕
image
I did not change anything to the existing code of this command. Could you retry this command?

@milanholemans
Copy link
Contributor Author

Weird! 😄
image

MathijsVerbeeck added a commit to MathijsVerbeeck/cli-microsoft365 that referenced this issue Sep 17, 2024
@MathijsVerbeeck
Ensures output for list commands. Closes pnp#6288
d961eb5
@MathijsVerbeeck MathijsVerbeeck mentioned this issue Sep 17, 2024
Closed
@milanholemans milanholemans mentioned this issue Sep 17, 2024
Closed
@MathijsVerbeeck MathijsVerbeeck linked a pull request Sep 17, 2024 that will close this issue
Ensures output for list commands #6359
Closed
MathijsVerbeeck added a commit to MathijsVerbeeck/cli-microsoft365 that referenced this issue Sep 20, 2024
@MathijsVerbeeck
Ensures output for list commands. Closes pnp#6288
efeec08
milanholemans pushed a commit to MathijsVerbeeck/cli-microsoft365 that referenced this issue Sep 21, 2024
@MathijsVerbeeck @milanholemans
Ensures output for list commands. Closes pnp#6288
729ac71
milanholemans pushed a commit to MathijsVerbeeck/cli-microsoft365 that referenced this issue Sep 21, 2024
@MathijsVerbeeck @milanholemans
Ensures output for list commands. Closes pnp#6288
a7ecf63
milanholemans pushed a commit that referenced this issue Sep 21, 2024
@MathijsVerbeeck @milanholemans
Ensures empty output for various 'list' commands. Closes #6288
90ff060
MathijsVerbeeck added a commit that referenced this issue Sep 24, 2024
@MathijsVerbeeck
Ensures empty output for various 'list' commands. Closes #6288
255b533
Adam-it pushed a commit that referenced this issue Sep 27, 2024
@MathijsVerbeeck @Adam-it
Ensures empty output for various 'list' commands. Closes #6288
ef86f14
ktskumar pushed a commit to ktskumar/cli-microsoft365 that referenced this issue Oct 8, 2024
@MathijsVerbeeck @ktskumar
Ensures empty output for various 'list' commands. Closes pnp#6288
e23b06c
ktskumar pushed a commit to ktskumar/cli-microsoft365 that referenced this issue Oct 16, 2024
@MathijsVerbeeck @ktskumar
Ensures empty output for various 'list' commands. Closes pnp#6288
82243ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MathijsVerbeeck MathijsVerbeeck

Labels
breaking change work in progress
Projects
None yet
Milestone
v10
Development

Successfully merging a pull request may close this issue.

Ensures output for list commands MathijsVerbeeck/cli-microsoft365
2 participants
@MathijsVerbeeck @milanholemans