Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: support uploading image for Image column #2503

Merged
merged 4 commits into from
Oct 31, 2022

Conversation

gautamdsheth
Copy link
Collaborator

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

NA

What is in this Pull Request ?

Supports uploading image to the site assets library for image column

@KoenZomers
Copy link
Collaborator

@gautamdsheth What will we do with this one for the next release as I believe we discussed this implementation is quite minimalistic?

@gautamdsheth
Copy link
Collaborator Author

@KoenZomers - I guess we can squeeze it in for this release ?

@KoenZomers
Copy link
Collaborator

@KoenZomers Don't you think we'll make it difficult for ourselves to evolve on this in a future version with backwards compatibility if we do? If you think we can work our way through that, let's merge and see what kind of feedback we receive on shortcomings.

@gautamdsheth
Copy link
Collaborator Author

@KoenZomers - we should be ok now. Was a bit difficult in current format because we were reliant on existing uploaded files. The parameter -ServerRelativePath makes more sense IMHO for that scenario. We can use -Path parameter for file to be uploaded from the local file system, which makes more sense.

Thoughts?

@KoenZomers
Copy link
Collaborator

Let's do it then

@gautamdsheth gautamdsheth merged commit e682779 into pnp:dev Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants