Changes to Add-PnPNavigationNode
#2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
@KoenZomers - I would have approved this PR yesterday but then I attended the PnP community call where Bert mentioned that he added Audience targeting support in PnP Core SDK 😊 Can we maybe use that ? Check this link: https://pnp.github.io/pnpcore/using-the-sdk/audience-targeting-intro.html#in-navigation If you want, I can write a separate PR for that. |
|
Interesting. He seems to create the JSON himself and post that to the new endpoints. Would make things more efficient, but needs testing if it works well. Wish I would have known this before. Would have saves me a few hours of getting it to work this way :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
Fixes #2708
What is in this Pull Request ?
Add-PnPNavigationNodenot always showing the new navigation node without requiring a manual edit and save of the menu first-AudienceIdsoption toAdd-PnPNavitationNodeto allow setting the audience for a navigation node