Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New command Get-PnPPowerApp #2794

Merged
merged 9 commits into from
Mar 23, 2023
Merged

New command Get-PnPPowerApp #2794

merged 9 commits into from
Mar 23, 2023

Conversation

siddharth-vaghasia
Copy link
Contributor

Type

  • New Feature

What is in this Pull Request?

Added new command to get the list of Power Apps from the environment, also support for getting specific Power App by passing Identify as a parameter.

Note - Doing PR here for the first time, so all the code review comments are welcome.....

Guidance

  • You can delete this section when you are submitting the pull request.*
  • Please update this PR information accordingly. We use this as part of our release notes in monthly communications.
  • Please target your PR to Dev branch. If you do not target the Dev branch we will not accept this PR.

@gautamdsheth
Copy link
Collaborator

Hi @siddharth-vaghasia , amazing stuff. Really glad to see you contribute here 😊

Have a few comments :)

Does Get-PnPPowerAutomateApp or Get-PnPPowerPlatformApp make it more clear ? Maybe we can use that.

Can you please capitalize the properties in the PowerApp.cs ?

The file PowerAppProperties.cs contains a bunch of classes in the single file , can you please make them as separate files ?

@siddharth-vaghasia
Copy link
Contributor Author

Hey @gautamdsheth - thanks for reviewing.... please find comments inline

Does Get-PnPPowerAutomateApp or Get-PnPPowerPlatformApp make it more clear? Maybe we can use that.
[Comment] - Actually in general terms we call it PowerApp.... PowerPlatform is a broader term that has PowerApps, PowerAutomat, and PowerBI as products within.... to keep it consistent with Get-PnPFlow like I have kept it as Get-PnPPowerApp because PowerApp is other product with same suite of products...Also same is the name of a command in PowerApps Powershell. Get-PowerApp.. let me know your thoughts.

Can you please capitalize the properties in the PowerApp.cs ?
[Comment] - working on this
The file PowerAppProperties.cs contains a bunch of classes in the single file , can you please make them as separate files ?
[Comment] - working on this

@gautamdsheth
Copy link
Collaborator

@siddharth-vaghasia - let me know whenever the API or authentication is stable enough, will take a look then, keeping it open for now :)

@KoenZomers
Copy link
Collaborator

Any updates on this @siddharth-vaghasia ?

@siddharth-vaghasia
Copy link
Contributor Author

Hi @KoenZomers - I am waiting for to know final scope to be added ton PnP App Registration, it is tracked here
pnp/cli-microsoft365#4460

@siddharth-vaghasia
Copy link
Contributor Author

Hey @gautamdsheth @KoenZomers - Seems the API is working again now and tested it, can you please verify

image

image

gautamdsheth and others added 3 commits March 23, 2023 16:07
…ement.azure.com requests to avoid redundant code and stay in line with other cmdlet inherritance, added several options around not requiring an environment to be specified
@KoenZomers KoenZomers merged commit 63fc2d2 into pnp:dev Mar 23, 2023
@KoenZomers
Copy link
Collaborator

Thanks @siddharth-vaghasia for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants