-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support document library owner to make change of the file version trim mode #2869
Conversation
Thanks for contributing @msjennywu! I cannot get this compiled on my machine and as you can see, it also doesn't compile in the Git Actions process. Can you elaborate how you got the properties you're using? Perhaps a newer CSOM library version than we're using? |
|
@KoenZomers Thanks for the review! Yes, it uses new properties which is not in the published library yet. This is my first time to make the change here. I'm trying to send out review and get comments as earlier as possible. Please feel free to let me know if this PR impacts you guys or break anything. Thanks so much! |
Thanks for elaborating. Which CSOM library version did you compile this against and where did you get it from? |
I use the "Microsoft.Sharepoint.Client.dll" that built in my local Sharepoint repository. Replaced the one in nuget packages folder. |
@msjennywu Its still unclear to me where you got the CSOM library from. I haven't heard yet that Microsoft was working on the functionality you're adding. Can you share more on where you got this from? It still doesn't build here nor in GitHub Actions. |
Ah, my previous change is till not published I think. My CSOM change in Sharepoint is in build [16.0.23415.12000], but the published one here https://www.nuget.org/packages/Microsoft.SharePointOnline.CSOM is 16.0.23408.12000. Should I close my PR to unblock your building? And open it when my change is published? Please feel free to ping me (jennywu) on MS teams. |
These changes will be out with the CSOM release planned to get out in 31st of March. Let's double check the situation again then and move forward as needed. |
… renames in the future
Works now with the newly released CSOM library. Thanks @msjennywu for your contribution! |
I was very curious about this PR mentioned in the latest release notes. I couldn't find any documentation from CSOM about it but then SPO answered me when I tried to change these properties:
Cool feature, can't wait for it to be GA 🚀 |
Interesting feature indeed! More on this will be released in the near future. |
Type
Related Issues?
NA
What is in this Pull Request ?
[FileVersion] Support document library owner to make change of the file version trim mode