Add retry logic to Submit-PnPSearchQuery #3528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and just simply always retry
…ubmitpnpsearchquery2
…exception to be thrown if it still happens on the last attempt
|
Nice one @koskila . Thanks for contributing. Made a small modification. Let's merge this into our nightlies and see if all works well and modify if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
Fixes #3454 (?)
What is in this Pull Request ?
This Pull Request offers one possible fix to issue #3454 by implementing a simple retry (with a switch called -RetryCount) for trying a failed search call again for x times. No upper limit, but backoff is incremental so it won't bombard the API.
My first implementation used Reflection to figure out what sort of an exception it is to make it possible to fail for some and retry others - but I don't have a good list of which exceptions are transient and which aren't, and some can be either one (like arguably the most usual one, "Microsoft.Office.Server.Search.Query.InternalQueryErrorException") so that differentiation doesn't necessarily make sense anyway... 🙄
I updated the documentation to include the new switch.