Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support volta, asdf, and package.json engines for declaring version #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

happycollision
Copy link

⚠️ I only ran the build script. Not sure if there is anything else needed.

This addresses #109 and #84 and could be extended later to also address #150.

Using the same logic as actions/setup-node, we can support asdf, volta or other version management techniques.

I thought it'd be nice to allow something like this:

on:
  - push
  - pull_request

jobs:
  install:
    runs-on: ubuntu-latest

    steps:
      - uses: pnpm/action-setup@v4
        with:
          version_file_path: ".tool-versions" # with asdf
          # version_file_path: "package.json" # with volta or package.json's `engines`

Using the same logic as `actions/setup-node`, we can support `asdf`, `volta` or other version management techniques.
@happycollision happycollision changed the title Support volta, asdf, and package.json engines feat: Support volta, asdf, and package.json engines for declaring version Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant