Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: try support packageManager #33

Merged
merged 5 commits into from
Feb 22, 2022
Merged

feat: try support packageManager #33

merged 5 commits into from
Feb 22, 2022

Conversation

Jack-Works
Copy link
Member

close #24

KSXGitHub
KSXGitHub requested changes Feb 22, 2022
View reviewed changes
src/install-pnpm/run.ts Outdated Show resolved Hide resolved
src/install-pnpm/run.ts Outdated Show resolved Hide resolved
@KSXGitHub KSXGitHub requested a review from zkochan February 22, 2022 04:34
KSXGitHub
KSXGitHub reviewed Feb 22, 2022
View reviewed changes
src/install-pnpm/run.ts Outdated Show resolved Hide resolved
KSXGitHub
KSXGitHub reviewed Feb 22, 2022
View reviewed changes
src/install-pnpm/run.ts Outdated Show resolved Hide resolved
KSXGitHub
KSXGitHub reviewed Feb 22, 2022
View reviewed changes
src/install-pnpm/run.ts Outdated Show resolved Hide resolved
KSXGitHub
KSXGitHub approved these changes Feb 22, 2022
View reviewed changes
Copy link
Collaborator

@KSXGitHub KSXGitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time, please remember to run pnpm run build before every commit.

@zkochan If you also approve this change, feel free to merge.

zkochan
zkochan reviewed Feb 22, 2022
View reviewed changes
src/install-pnpm/run.ts Outdated Show resolved Hide resolved
@KSXGitHub KSXGitHub merged commit 847a737 into master Feb 22, 2022
@KSXGitHub KSXGitHub deleted the packageManager branch February 22, 2022 09:39
@JuanM04 JuanM04 mentioned this pull request Mar 9, 2022
Merged
@mrm007 mrm007 mentioned this pull request Sep 8, 2022
Merged
@karlhorky karlhorky mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KSXGitHub KSXGitHub KSXGitHub approved these changes

@zkochan zkochan zkochan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature request] Use version of pnpm specified in package.json
3 participants
@Jack-Works @zkochan @KSXGitHub