fix(install/clean): infinite loops on circular dependencies #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
await-ovo
force-pushed
the
fix-circular-deps
branch
from
7de11ef
to
3098022
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
+ Coverage 92.65% 92.68% +0.02%
==========================================
Files 57 57
Lines 2847 2871 +24
==========================================
+ Hits 2638 2661 +23
- Misses 209 210 +1 ☔ View full report in Codecov by Sentry. |
KSXGitHub
requested changes
Nov 21, 2023
zkochan
reviewed
Nov 22, 2023
crates/cli/tests/install.rs
Outdated
|
|
||
| eprintln!("Snapshot"); | ||
| let index_file_contents = index_file_contents(&store_dir); | ||
| insta::assert_yaml_snapshot!(index_file_contents); |
There was a problem hiding this comment.
do really need this snapshot test? Maybe just check if the package is present in node_modules.
await-ovo
force-pushed
the
fix-circular-deps
branch
from
3098022
to
c2b121c
Compare
KSXGitHub
changed the title
KSXGitHub
approved these changes
Nov 22, 2023
zkochan
approved these changes
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
resolved_packagesmemo cache to state to avoid infinite loops when installing circular dependencies