Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't crash on a .npmrc with missing env var #5127

Merged
merged 2 commits into from
Jul 31, 2022
Merged

fix: don't crash on a .npmrc with missing env var #5127

merged 2 commits into from
Jul 31, 2022

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Jul 31, 2022

close #5093

@zkochan zkochan merged commit 34121d7 into main Jul 31, 2022
@zkochan zkochan deleted the fix/5093 branch July 31, 2022 00:36
This was referenced Jul 31, 2022
kodiakhq bot pushed a commit to mheob/config that referenced this pull request Aug 13, 2022
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pnpm](https://pnpm.io) ([source](https://github.com/pnpm/pnpm)) | [`7.6.0` -> `7.9.0`](https://renovatebot.com/diffs/npm/pnpm/7.6.0/7.9.0) | [![age](https://badges.renovateapi.com/packages/npm/pnpm/7.9.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/pnpm/7.9.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/pnpm/7.9.0/compatibility-slim/7.6.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/pnpm/7.9.0/confidence-slim/7.6.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>pnpm/pnpm</summary>

### [`v7.9.0`](https://github.com/pnpm/pnpm/releases/tag/v7.9.0)

[Compare Source](https://github.com/pnpm/pnpm/compare/v7.8.0...v7.9.0)

#### Minor Changes

-   When `ignore-dep-scripts` is `true`, ignore scripts of dependencies but run the scripts of the project.
-   When `ignore-compatibility-db` is set to `true`, the [compatibility database](https://github.com/yarnpkg/berry/blob/master/packages/yarnpkg-extensions/sources/index.ts) will not be used to patch dependencies [#&#8203;5132](https://github.com/pnpm/pnpm/issues/5132).
-   Print the versions of packages in peer dependency warnings and errors.
-   Support a new hook for passing a custom package importer to the store controller.

#### Patch Changes

-   Don't print the same deprecation warning multiple times.
-   On POSIX `pnpm setup` should suggest users to source the config instead of restarting the terminal.
-   Installing a package with `bin` that points to an `.exe` file on Windows [#&#8203;5159](https://github.com/pnpm/pnpm/issues/5159).
-   Fix bug where the package manifest was not resolved if `verify-store-integrity` is set to `false`.
-   Fix sorting of keys in lockfile to make it more deterministic and prevent unnecessary churn in the lockfile [#&#8203;5151](https://github.com/pnpm/pnpm/pull/5151).
-   Don't create a separate bundle for pnpx.

#### Our Gold Sponsors

<table>
  <tbody>
    <tr>
      <td align="center" valign="middle">
        <a href="https://bit.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/bit.svg" width="80"></a>
      </td>
      <td align="center" valign="middle">
        <a href="https://nhost.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/nhost.svg" width="180"></a>
      </td>
      <td align="center" valign="middle">
        <a href="https://novu.co/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/novu.svg" width="180"></a>
      </td>
    </tr>
  </tbody>
</table>
#### Our Silver Sponsors

<table>
  <tbody>
    <tr>
      <td align="center" valign="middle">
        <a href="https://prisma.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/prisma.svg" width="180"></a>
      </td>
      <td align="center" valign="middle">
        <a href="https://leniolabs.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/leniolabs.jpg" width="80"></a>
      </td>
      <td align="center" valign="middle">
        <a href="https://vercel.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/vercel.svg" width="180"></a>
      </td>
      <td align="center" valign="middle">
        <a href="https://www.takeshape.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/takeshape.svg" width="280"></a>
      </td>
    </tr>
  </tbody>
</table>

### [`v7.8.0`](https://github.com/pnpm/pnpm/releases/tag/v7.8.0)

[Compare Source](https://github.com/pnpm/pnpm/compare/v7.7.1...v7.8.0)

#### Minor Changes

-   When `publishConfig.directory` is set, only symlink it to other workspace projects if `publishConfig.linkDirectory` is set to `true`. Otherwise, only use it for publishing [#&#8203;5115](https://github.com/pnpm/pnpm/issues/5115).

#### Patch Changes

-   Don't incorrectly identify a lockfile out-of-date when the package has a publishConfig.directory field [#&#8203;5124](https://github.com/pnpm/pnpm/issues/5124).
-   Don't crash when a config file contains a setting with an env variable that doesn't exist [#&#8203;5093](https://github.com/pnpm/pnpm/issues/5093).

#### Our Gold Sponsors

<table>
  <tbody>
    <tr>
      <td align="center" valign="middle">
        <a href="https://bit.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/bit.svg" width="80"></a>
      </td>
      <td align="center" valign="middle">
        <a href="https://nhost.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/nhost.svg" width="180"></a>
      </td>
      <td align="center" valign="middle">
        <a href="https://novu.co/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/novu.svg" width="180"></a>
      </td>
    </tr>
  </tbody>
</table>
#### Our Silver Sponsors

<table>
  <tbody>
    <tr>
      <td align="center" valign="middle">
        <a href="https://prisma.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/prisma.svg" width="180"></a>
      </td>
      <td align="center" valign="middle">
        <a href="https://leniolabs.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/leniolabs.jpg" width="80"></a>
      </td>
      <td align="center" valign="middle">
        <a href="https://vercel.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/vercel.svg" width="180"></a>
      </td>
      <td align="center" valign="middle">
        <a href="https://www.takeshape.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/takeshape.svg" width="280"></a>
      </td>
    </tr>
  </tbody>
</table>
#### What's Changed
* fix: don't incorrectly identify a lockfile out-of-date by @&#8203;zkochan in pnpm/pnpm#5126
* feat: publishConfig.linkDirectory by @&#8203;zkochan in pnpm/pnpm#5125
* fix: don't crash on a .npmrc with missing env var by @&#8203;zkochan in pnpm/pnpm#5127
* chore: fix typo by @&#8203;LuciNyan in pnpm/pnpm#5128
#### New Contributors
* @&#8203;LuciNyan made their first contribution in pnpm/pnpm#5128

**Full Changelog**: pnpm/pnpm@v7.7.1...v7.8.0

### [`v7.7.1`](https://github.com/pnpm/pnpm/releases/tag/v7.7.1)

[Compare Source](https://github.com/pnpm/pnpm/compare/v7.7.0...v7.7.1)

#### Patch Changes

-   pnpm should not consider a lockfile out-of-date if `auto-install-peers` is set to `true` and the peer dependency is in `devDependencies` or `optionalDependencies` [#&#8203;5080](https://github.com/pnpm/pnpm/issues/5080).
-   Don't incorrectly consider a lockfile out-of-date when `workspace:^` or `workspace:~` version specs are used in a workspace.

#### Our Gold Sponsors

<table>
  <tbody>
    <tr>
      <td align="center" valign="middle">
        <a href="https://bit.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/bit.svg" width="80"></a>
      </td>
      <td align="center" valign="middle">
        <a href="https://nhost.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/nhost.svg" width="180"></a>
      </td>
      <td align="center" valign="middle">
        <a href="https://novu.co/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/novu.svg" width="180"></a>
      </td>
    </tr>
  </tbody>
</table>
#### Our Silver Sponsors

<table>
  <tbody>
    <tr>
      <td align="center" valign="middle">
        <a href="https://prisma.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/prisma.svg" width="180"></a>
      </td>
      <td align="center" valign="middle">
        <a href="https://leniolabs.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/leniolabs.jpg" width="80"></a>
      </td>
      <td align="center" valign="middle">
        <a href="https://vercel.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/vercel.svg" width="180"></a>
      </td>
      <td align="center" valign="middle">
        <a href="https://www.takeshape.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/takeshape.svg" width="280"></a>
      </td>
    </tr>
  </tbody>
</table>
#### What's Changed
* fix: frozen install in a project with peer deps and `auto-install-peers=true` by @&#8203;zkochan in pnpm/pnpm#5120
* fix: don't incorrectly consider a lockfile to be out-of-date by @&#8203;zkochan in pnpm/pnpm#5121

**Full Changelog**: pnpm/pnpm@v7.7.0...v7.7.1

### [`v7.7.0`](https://github.com/pnpm/pnpm/releases/tag/v7.7.0)

[Compare Source](https://github.com/pnpm/pnpm/compare/v7.6.0...v7.7.0)

#### Minor Changes

-   Add experimental lockfile format that should merge conflict less in the `importers` section. Enabled by setting the `use-inline-specifiers-lockfile-format = true` feature flag in `.npmrc`.

    If this feature flag is committed to a repo, we recommend setting the minimum allowed version of pnpm to this release in the `package.json` `engines` field. Once this is set, older pnpm versions will throw on invalid lockfile versions.

-   Add `publishDirectory` field to the lockfile and relink the project when it changes.

-   `verify-store-integrity=false` makes pnpm skip checking the integrities of files in the global content-addressable store.

-   Allow to set `only-built-dependencies[]` through `.npmrc`.

#### Patch Changes

-   It should be possible to publish a package with local dependencies from a custom publish directory (set via `publishConfig.directory`) [#&#8203;3901](https://github.com/pnpm/pnpm/issues/3901#issuecomment-1194156886).
-   `pnpm deploy` should inject local dependencies of all types (dependencies, optionalDependencies, devDependencies) [#&#8203;5078](https://github.com/pnpm/pnpm/issues/5078).
-   When a project in a workspace has a `publishConfig.directory` set, dependent projects should install the project from that directory [#&#8203;3901](https://github.com/pnpm/pnpm/issues/3901)
-   **pnpm deploy**: accept absolute paths and use cwd instead of workspaceDir for deploy target directory [#&#8203;4980](https://github.com/pnpm/pnpm/issues/4980).
-   **pnpm setup** should update `.zshrc` in the right directory when a `$ZDOTDIR` is set.

#### Our Gold Sponsors

<table>
  <tbody>
    <tr>
      <td align="center" valign="middle">
        <a href="https://bit.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/bit.svg" width="80"></a>
      </td>
      <td align="center" valign="middle">
        <a href="https://nhost.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/nhost.svg" width="180"></a>
      </td>
      <td align="center" valign="middle">
        <a href="https://novu.co/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/novu.svg" width="180"></a>
      </td>
    </tr>
  </tbody>
</table>
#### Our Silver Sponsors

<table>
  <tbody>
    <tr>
      <td align="center" valign="middle">
        <a href="https://prisma.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/prisma.svg" width="180"></a>
      </td>
      <td align="center" valign="middle">
        <a href="https://leniolabs.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/leniolabs.jpg" width="80"></a>
      </td>
      <td align="center" valign="middle">
        <a href="https://vercel.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/vercel.svg" width="180"></a>
      </td>
      <td align="center" valign="middle">
        <a href="https://www.takeshape.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/takeshape.svg" width="280"></a>
      </td>
    </tr>
  </tbody>
</table>
#### What's Changed
* fix(deploy): inject all types of deps by @&#8203;zkochan in pnpm/pnpm#5084
* fix(make-dedicated-lockfile): prepublishOnly script is automatically … by @&#8203;zkochan in pnpm/pnpm#5083
* fix: symlink a workspace pkg correctly, when it has a custom publish dir by @&#8203;zkochan in pnpm/pnpm#5089
* feat: add experimental use-inline-specifiers-lockfile-format  by @&#8203;gluxon in pnpm/pnpm#5091
* fix: plugin-commands-deploy use path resolve on deploy target dir by @&#8203;AWare in pnpm/pnpm#5026
* fix: relink the project when its publish directory changes by @&#8203;zkochan in pnpm/pnpm#5109
* fix: don't include specifiers field in new experimental lockfile format by @&#8203;zkochan in pnpm/pnpm#5110
* feat: verify-store-integrity by @&#8203;zkochan in pnpm/pnpm#5112
#### New Contributors
* @&#8203;AWare made their first contribution in pnpm/pnpm#5026

**Full Changelog**: pnpm/pnpm@v7.6.0...v7.7.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 5am on Wednesday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/mheob/config).
@zkochan zkochan added this to the v7.8 milestone Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR  Failed to replace env in config: ${NPM_GITHUB_TOKEN}
1 participant