fix: node<16 download fail on arm chips on macos #5239
Conversation
|
💖 Thanks for opening this pull request! 💖 |
|
I am required to add copyright mark to files I modify when making work related opensource contributions. |
|
No, I don't think we will accept changes with license changes. |
|
@zkochan This is not a license change. The comment has same license as pnpm (MIT). |
|
I am against this copyright notice. First of all, we don't put copyright notice to individual files. Secondly, this changes only 3 lines of code in a file edited by other contributors but you add a copyright notice of a company. This recommendation of VMware makes sense for open-source projects maintained by VMware but not in this case. |
Add a check for macos apple silicon and required node version < 16. In such case, download x64 binary. Because arm build does not exist. Previous behaviour: Try to download non existing arm build and fail with 404. NO breaking change fixes pnpm#4489
|
Congrats on merging your first pull request! 🎉🎉🎉 |
Add a check for macos apple silicon and required node version < 16.
In such case, download x64 binary.
Because arm build does not exist.
Macos automatically detects x64 instructions and converts them so downloaded node works as expected.
Previous behaviour:
Try to download non existing arm build and fail with 404.
NO breaking change
fixes #4489