Skip to content

Commit

Permalink
Merge pull request #40 from terop/fixes
Browse files Browse the repository at this point in the history
Do various changes
  • Loading branch information
pnuu authored Aug 11, 2023
2 parents d0d5f0f + c6aec72 commit 1b2b0aa
Show file tree
Hide file tree
Showing 8 changed files with 31 additions and 46 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,15 @@ For `radar` datasets `rasterio` is needed. It can be installed with
This library provides two very simple scripts that list all the available data on
FMI open data WMS and WFS services.

Create `wms.html` that lists all the availble WMS layers:
Create `wms.html` that lists all the available WMS layers:
```bash

wms_html.py
```

The `Layer ID` strings are used to identify WMS (image) datasets. Examples to be added.

Create `wfs.html` that lists all the availble WFS layers:
Create `wfs.html` that lists all the available WFS layers:
```bash

wfs_html.py
Expand Down Expand Up @@ -131,7 +131,7 @@ plt.imshow(composite.data[0, :, :])
plt.show()
```

The following attributes are available in the underlaying `Radar` class for all radar data:
The following attributes are available in the underlying `Radar` class for all radar data:

```python

Expand Down
3 changes: 0 additions & 3 deletions fmiopendata/grid.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@
import defusedxml.ElementTree as ET
import os
import tempfile
import sys
if sys.version_info < (3, 6):
from collections import OrderedDict as dict

import numpy as np
import eccodes
Expand Down
3 changes: 0 additions & 3 deletions fmiopendata/multipoint.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@

import defusedxml.ElementTree as ET
import datetime as dt
import sys
if sys.version_info < (3, 6):
from collections import OrderedDict as dict

import numpy as np

Expand Down
3 changes: 0 additions & 3 deletions fmiopendata/radar.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@
import datetime as dt
import defusedxml.ElementTree as ET
import tempfile
import sys
if sys.version_info < (3, 6):
from collections import OrderedDict as dict

import rasterio
import numpy as np
Expand Down
2 changes: 1 addition & 1 deletion fmiopendata/tests/test_lightning.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def test_lightning():
# The multipoint coverage format
res2 = download_and_parse("fmi::observations::lightning::multipointcoverage", args=ARGS)

# The results should be indentical
# The results should be identical
assert np.all(res.latitudes == res2.latitudes)
assert np.all(res.longitudes == res2.longitudes)
assert np.all(res.times == res2.times)
Expand Down
7 changes: 2 additions & 5 deletions fmiopendata/wfs.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,12 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.

import defusedxml.ElementTree as ET
import sys
if sys.version_info < (3, 6):
from collections import OrderedDict as dict

from fmiopendata.utils import read_url


BASE_URL = "http://opendata.fmi.fi/wfs?service=WFS&request="
STORED_QUERY_URL = "http://opendata.fmi.fi/wfs?service=WFS&version=2.0.0&request=getFeature&storedquery_id="
BASE_URL = "https://opendata.fmi.fi/wfs?service=WFS&request="
STORED_QUERY_URL = "https://opendata.fmi.fi/wfs?service=WFS&version=2.0.0&request=getFeature&storedquery_id="

GML_BEGIN_POSITION = ".//{http://www.opengis.net/gml/3.2}beginPosition"
GML_DOUBLE_OR_NIL_REASON_TUPLE_LIST = ".//{http://www.opengis.net/gml/3.2}doubleOrNilReasonTupleList"
Expand Down
3 changes: 0 additions & 3 deletions fmiopendata/wms.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@

import datetime as dt
import defusedxml.ElementTree as ET
import sys
if sys.version_info < (3, 6):
from collections import OrderedDict as dict

from fmiopendata.utils import read_url

Expand Down
50 changes: 25 additions & 25 deletions wfs.md

Large diffs are not rendered by default.

0 comments on commit 1b2b0aa

Please sign in to comment.