Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix timeseries key names #42

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Bugfix timeseries key names #42

merged 2 commits into from
Oct 27, 2023

Conversation

pnuu
Copy link
Owner

@pnuu pnuu commented Oct 27, 2023

The measurement keys ("titles") for timeseries observations were using the standard short-form naming, such as 't2m' instead of the human-readable "Air temperature" that are used when timeseries=False is used. This PR harmonizes the timeseries=True case to use the longer key names.

@pnuu pnuu added bug Something isn't working documentation Improvements or additions to documentation labels Oct 27, 2023
@pnuu pnuu self-assigned this Oct 27, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b8f5e3) 90.61% compared to head (d40157e) 90.61%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage   90.61%   90.61%           
=======================================
  Files          16       16           
  Lines         970      970           
=======================================
  Hits          879      879           
  Misses         91       91           
Files Coverage Δ
fmiopendata/multipoint.py 97.02% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnuu pnuu merged commit 66a370a into main Oct 27, 2023
8 checks passed
@pnuu pnuu deleted the bugfix-timeseries-key-names branch October 27, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants