Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename DistAlgorithm to ConsensusProtocol. #377

Merged
merged 1 commit into from
Jan 8, 2019
Merged

Rename DistAlgorithm to ConsensusProtocol. #377

merged 1 commit into from
Jan 8, 2019

Conversation

afck
Copy link
Collaborator

@afck afck commented Jan 8, 2019

See #347.

@afck afck requested review from vkomenda and andogro January 8, 2019 08:33
vkomenda
vkomenda reviewed Jan 8, 2019
View reviewed changes
Copy link
Contributor

@vkomenda vkomenda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still a mention of DistAlgorithm in a doc comment:

hbbft/src/fault_log.rs

Line 5 in 7c42a2b

//! `DistAlgorihm`'s `.handle_input()` and `.handle_message()` trait methods.
.
Otherwise I'm fine with the renaming.

@afck
Copy link
Collaborator Author

afck commented Jan 8, 2019

Good catch, thanks! That wasn't replaced because it had a typo. 😅

@afck afck merged commit 87b1d45 into master Jan 8, 2019
@afck afck deleted the afck-rename branch January 8, 2019 13:14
@mbr mbr mentioned this pull request Jan 8, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkomenda vkomenda vkomenda approved these changes

@andogro andogro Awaiting requested review from andogro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afck @vkomenda