-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kovan spec for Istanbul #122
Conversation
Reference in parity repository openethereum/parity-ethereum@2627288
Needs to be tested when parity version with Istanbul is actually released |
Doesn't v2.6.3-beta support Istanbul already? Or it is not fully supported yet? |
As I understand 2.6.3 has support for Istanbul but doesn't set any HF activation dates. They are set in openethereum/parity-ethereum#11068 which is not released yet. |
In the recently released parity 2.6.4 this spec is accepted and starts to sync, so this PR is ready for review |
I've compared https://github.com/paritytech/parity-ethereum/blob/v2.6.4/ethcore/res/ethereum/kovan.json with https://github.com/poanetwork/poa-chain-spec/blob/phahulin-patch-1/spec.json It seems we have differences in the next sections of the spec:
Parity's
Our
And our has much more items in the The diff file is attached: diff.txt |
Thanks for noticing. According to docs those values are used by light-clients, so I suppose we can copy them from parity repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, now the files are identical.
Reference in parity repository
openethereum/parity-ethereum@2627288
Kovan HF is about to be activated at block
14111141
(~Sunday, 13-Oct-19 08:35 UTC
)