Simplify Poly multiplication, speed up interpolation. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/poly.rs
Outdated
| Err(e) => panic!("Failed to create a new `Poly` duing muliplication: {}", e), | ||
| let rhs = rhs.borrow(); | ||
| let mut coeff = vec![Fr::zero(); self.coeff.len() + rhs.borrow().coeff.len() - 1]; | ||
| let mut s = SecretKey::default(); // Temporary value will be zeroed on drop. |
There was a problem hiding this comment.
This is definitely an abuse of SecretKey, I agree that a Secret type (issue #24) should be added for situations such as these.
There was a problem hiding this comment.
Agreed. I removed it and added back the TODO.
Also add more `Mul` implementations.
|
I added another commit which speeds up interpolation by an additional ~45% on my machine. Division is expensive! |
|
And another one, which gives between 25% (degree 5) and 84% (degree 40) speedup. |
DrPeterVanNostrand
approved these changes
Sep 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces time for interpolation by about 20% on my machine.
Also add more
Mulimplementations.