Validate Poll Attestation Signature Upon Submission #18
Conversation
Explanation of changes can be found here: #5 (comment)
* Add PollValidator Unit Tests for attestation signature validation * Fix endpoint smoketests to work as expected with attestations now being included & validated * Refactor signature recovery into a helper method that can eventually be re-used for vote attestations
|
LGTM! One nit—line 43 of Like I said, super small thing, but figured I'd point it out and let you decide how to handle it. Feel free to rebase and merge afterwards! |
There was a problem hiding this comment.
GitHub has an "Add your review" button on the PR page since I was requested to review this PR. So I'm just repeating my previous comment here to try out this feature.
Comment from before
LGTM! One nit—line 43 of poll-validator-test.js spells attestation wrong, so doesn't actually delete the attestation key. But the thing is, deleting the key is unnecessary in multiple tests throughout this file, since the key is just overwritten anyway.
Like I said, super small thing, but figured I'd point it out and let you decide how to handle it.
Feel free to rebase and merge afterwards!
Edit: Oh, I think if I were to comment on specific lines of the diff it would show here. Pretty cool
Closes #5, with the exception of the bug documented in #17