Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Backend Validations For Poll Create & Voting #45

Merged
merged 3 commits into from
Apr 25, 2020
Merged

Additional Backend Validations For Poll Create & Voting #45

merged 3 commits into from
Apr 25, 2020

Conversation

apbendi
Copy link
Contributor

@apbendi apbendi commented Apr 25, 2020 •
edited
Loading

Addresses two portions of #9:

  • Validate poll option chosen when submitting a vote actually exists & belongs to the poll
  • Validate all event ids listed as "valid" for this poll actually exist in the POAP system

Run npm install & npm test

@apbendi apbendi requested a review from mds1 April 25, 2020 11:19
@apbendi
Validate qualifying event Ids actually exist on POAP
02c8404 
* Import axios & use it to fetch events from the POAP
  API to validate events exist on Poll creation
* Endpoint smoke test for this validation, note: means
  we're hitting prod POAP api during test execution
* Update PollValidator unit tests to account for the
  event existence validation
@apbendi apbendi changed the title Validate Poll Option Selected When Voting Belongs To Associated Poll Additional Backend Validations For Poll Create & Voting Apr 25, 2020
@mds1
Copy link
Contributor

mds1 commented Apr 25, 2020

Looks good and tests pass, will merge now

@mds1 mds1 merged commit 02c8404 into master Apr 25, 2020
@apbendi apbendi deleted the vote-option-validation branch April 28, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mds1 mds1 Awaiting requested review from mds1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apbendi @mds1