✨ Feature: Changing core api url backend #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alavarello
approved these changes
May 2, 2022
pablojp
reviewed
May 2, 2022
| @@ -3,12 +3,12 @@ import axios from 'axios'; | |||
| class POAP { | |||
|
|
|||
| static async fetchEvents() { | |||
| const response = await axios.get('https://api.poap.xyz/events'); | |||
| const response = await axios.get('https://api.poap.tech/events'); | |||
There was a problem hiding this comment.
Create a Jira ticket with technical debt to move this URL to an environment variable and add the ticket in this comment.
There was a problem hiding this comment.
This is now part of the proposed enhancement in https://poap-devs.atlassian.net/browse/PLT-218
pablojp
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-Changing core api url
api.poap.xyzforapi.poap.techin backendCloses issues
Types of Changes
Select at least one of these type of changes.
QA Checklist
developmentbefore creating the pull-request