Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit variations only to skin-tone #8

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

pocka
Copy link
Owner

@pocka pocka commented Jun 3, 2019

Fix #6

To parse an emoji sequence correctly, treat only :foo::skin-tone-bar: as emoji with variations.

* To parse sequential emojis.
@pocka pocka added the bug Something isn't working label Jun 3, 2019
@pocka pocka self-assigned this Jun 3, 2019
@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #8   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         105    105           
  Branches        9      9           
=====================================
  Hits          105    105
Impacted Files Coverage Δ
src/parser.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddbbcc8...a43b1f1. Read the comment docs.

@pocka pocka merged commit 8c692bb into master Jun 3, 2019
@pocka pocka deleted the fix/limit-variation-to-skin-tone branch June 3, 2019 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emoji sequence not parsed correctly
1 participant