Skip to content

Commit

Permalink
Drop the expander borrow in all control flow paths
Browse files Browse the repository at this point in the history
The change in rust-lang#13123
actually re-uses the RefMut borrow instead of dropping it so we need to
drop it manually where required.
  • Loading branch information
Veykril authored and pocket7878 committed Aug 31, 2022
1 parent 0c4a6ec commit d6400f5
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion crates/hir-ty/src/lower.rs
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,10 @@ impl<'a> TyLoweringContext<'a> {
TypeRef::Macro(macro_call) => {
let (mut expander, recursion_start) = {
match RefMut::filter_map(self.expander.borrow_mut(), Option::as_mut) {
// There already is an expander here, this means we are already recursing
Ok(expander) => (expander, false),
// No expander was created yet, so we are at the start of the expansion recursion
// and therefore have to create an expander.
Err(expander) => (
RefMut::map(expander, |it| {
it.insert(Expander::new(
Expand Down Expand Up @@ -362,9 +365,14 @@ impl<'a> TyLoweringContext<'a> {
.exit(self.db.upcast(), mark);
Some(ty)
}
_ => None,
_ => {
drop(expander);
None
}
}
};

// drop the expander, resetting it to pre-recursion state
if recursion_start {
*self.expander.borrow_mut() = None;
}
Expand Down

0 comments on commit d6400f5

Please sign in to comment.