Add Typography component with ID and link button #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kachar
reviewed
Jun 21, 2021
kachar
reviewed
Jun 21, 2021
kachar
reviewed
Jun 21, 2021
kachar
reviewed
Jun 21, 2021
kachar
reviewed
Jun 21, 2021
kachar
approved these changes
Jun 22, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented higher order component of Typography that supports optional link button.
Motivation and context
This change provides an easy way to link section (and share it)
Issue #214
Edits are made on the styling of heading elements (margin is removed and padding is added because otherwise the heading hides under the navbar)
P.S:
Sorry if my implementation is not following best practices coming from different background
but I am ready to improve it :/
Screenshots: