Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Content-Type for JSON responses #346

Closed
banool opened this issue Jul 26, 2022 · 2 comments
Closed

Unify Content-Type for JSON responses #346

banool opened this issue Jul 26, 2022 · 2 comments
Labels
bug Something isn't working Stale

Comments

@banool
Copy link
Contributor

banool commented Jul 26, 2022

Hey, I see in some places in the code base, we use application/json as the Content-Type:

  • poem-openapi/src/payload/json.rs

Whereas in others, we use application/json; charset=utf-8:

  • poem/src/web/json.rs

I wonder is there a reason for this? If not, it'd be greater if we could return either one or the other in all cases.

@banool banool added the bug Something isn't working label Jul 26, 2022
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Aug 26, 2022
@github-actions
Copy link

This issue was closed because it has been stalled for 5 days with no activity.

sunli829 added a commit that referenced this issue Oct 18, 2022
sunli829 added a commit that referenced this issue Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
Development

No branches or pull requests

1 participant