Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 400 when parsing path fails, not 404 #326

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Return 400 when parsing path fails, not 404 #326

merged 1 commit into from
Jul 26, 2022

Conversation

banool
Copy link
Contributor

@banool banool commented Jul 19, 2022

All the other parse errors return 400, but this one returns 404. This PR makes it conform to the other parse errors.

@banool
Copy link
Contributor Author

banool commented Jul 25, 2022

Hey @sunli829 do you think we could land this? It should be good to go.

@sunli829
Copy link
Collaborator

Thanks! 🙂

@sunli829 sunli829 merged commit f8e11c1 into poem-web:master Jul 26, 2022
@banool banool deleted the parse_error branch July 26, 2022 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@banool @sunli829