Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authorship/licensing concern #29

Closed
stefanpenner opened this issue Jun 28, 2014 · 2 comments
Closed

authorship/licensing concern #29

stefanpenner opened this issue Jun 28, 2014 · 2 comments

Comments

@stefanpenner
Copy link

First let me say, this is a really cool project! Please read the rest of this issue while assuming a positive tone.

Although I love experimentation and do not want to stifle innovation, large amounts of this code-base originated from https://github.com/stefanpenner/ember-cli but have lost original authorship and licensing.

Some have nice little remarks: https://github.com/poetic/ember-cordova-cli/blob/master/lib/models/core-object.js#L1-L2 which I appreciate. It is likely best if the rest of the files which originated from ember-cli also had this shoutout. Until they have diverged significantly.

I would like to encourage you to continue to innovate.

I also acknowledge that ember-cli should begin to be broken into smaller modules so others can easily consume the parts they want.

Another idea would be to work on improving the addon extensibility of ember-cli: #28

@jakecraige
Copy link
Contributor

No problem. I've made some changes and added some comments in the referenced commit. If there is something that I missed let me know and I'll be glad to update it.

@stefanpenner
Copy link
Author

awesome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants