Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load wandb #228

Merged
merged 7 commits into from
Mar 23, 2022
Merged

Lazy load wandb #228

merged 7 commits into from
Mar 23, 2022

Conversation

cgarciae
Copy link
Collaborator

@cgarciae cgarciae commented Mar 23, 2022

Currently wandb is imported at the top-level making it a strict dependency, to avoid cluttering too much the dependency space, this PR add wandb as an optional dependecy which the user could install via the all extras tag:

pip install 'elegy[all]'

Additionally, this fixes the current error on wandb CI error on master.

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2022

Codecov Report

Merging #228 (979b5f5) into master (bc2483c) will increase coverage by 0.35%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
+ Coverage   67.25%   67.60%   +0.35%     
==========================================
  Files          31       31              
  Lines        2446     2479      +33     
==========================================
+ Hits         1645     1676      +31     
- Misses        801      803       +2     
Impacted Files Coverage Δ
elegy/callbacks/wandb_callback.py 11.21% <0.00%> (-1.05%) ⬇️
elegy/model/model_core.py 83.77% <100.00%> (ø)
elegy/model/model_base.py 84.86% <0.00%> (+0.08%) ⬆️
elegy/utils.py 37.30% <0.00%> (+0.32%) ⬆️
elegy/data/array_adapter.py 88.88% <0.00%> (+0.36%) ⬆️
elegy/data/dataset.py 84.61% <0.00%> (+0.55%) ⬆️
elegy/data/list_adapter.py 90.47% <0.00%> (+0.73%) ⬆️
elegy/data/tf_dataset_adapter.py 86.00% <0.00%> (+0.89%) ⬆️
elegy/data/data_handler.py 72.41% <0.00%> (+1.32%) ⬆️
elegy/data/torch_dataloader_adapter.py 75.47% <0.00%> (+1.47%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c690748...979b5f5. Read the comment docs.

@cgarciae cgarciae added the fix label Mar 23, 2022
@cgarciae cgarciae merged commit 1ebd306 into master Mar 23, 2022
@charlielito charlielito deleted the lazy-load-wandb branch March 24, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants