Tutorial fixes and updates #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafurman
commented
Apr 19, 2024
| @@ -1,6 +1,8 @@ | |||
| import ComposableArchitecture | |||
| import XCTest | |||
|
|
|||
| @testable import CounterApp | |||
There was a problem hiding this comment.
Just mimicking what's going on in the Navigation part, where the main app target is imported
dafurman
commented
Apr 19, 2024
| @@ -6,6 +6,6 @@ struct ContactDetailView: View { | |||
| var body: some View { | |||
| Form { | |||
| } | |||
| .navigationBarTitle(Text(store.contact.name)) | |||
| .navigationTitle(Text(store.contact.name)) | |||
There was a problem hiding this comment.
Switching from the deprecated navigationBarTitle to the newer modifier.
|
I didn't quite know how to address it in this PR, but I'm wondering if this bit should be rephrased:
Given that the example with the sheet is actually just using the native binding there: 
|
dafurman
commented
Apr 19, 2024
| @@ -87,7 +87,7 @@ struct InventoryFeature { | |||
| > Note: The key path used with `ifLet` focuses on the `@PresentationState` projected value since it | |||
| > uses the `$` syntax. Also note that the action uses a | |||
| > [case path](http://github.com/pointfreeco/swift-case-paths), which is analogous to key paths but | |||
| > tuned for enums, and uses the forward slash syntax. | |||
There was a problem hiding this comment.
The example above uses the newer backslash syntax 🥳
Good call! Will fix it up on |
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Apr 29, 2024
…ure to from: "1.10.0" (#1052) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [pointfreeco/swift-composable-architecture](https://github.com/pointfreeco/swift-composable-architecture) | minor | `from: "1.9.3"` -> `from: "1.10.0"` | --- ### Release Notes <details> <summary>pointfreeco/swift-composable-architecture (pointfreeco/swift-composable-architecture)</summary> ### [`v1.10.0`](https://github.com/pointfreeco/swift-composable-architecture/releases/tag/1.10.0) [Compare Source](https://github.com/pointfreeco/swift-composable-architecture/compare/1.9.3...1.10.0) #### What's Changed - Added: All new state sharing tools, including the `@Shared` property wrapper and more ([https://github.com/pointfreeco/swift-composable-architecture/pull/2858](https://github.com/pointfreeco/swift-composable-architecture/pull/2858)). (Thanks [@​NFulkerson](https://github.com/NFulkerson), [@​hallee](https://github.com/hallee), [@​pyrtsa](https://github.com/pyrtsa), [@​DandyLyons](https://github.com/DandyLyons), [@​hiltonc](https://github.com/hiltonc), [@​lukeredpath](https://github.com/lukeredpath), [@​andtie](https://github.com/andtie), [@​AlexKobachiJP](https://github.com/AlexKobachiJP), [@​ZevEisenberg](https://github.com/ZevEisenberg), for their contributions!) - Updated: Bumped swift-collections to remove `@unchecked` from `StackState`'s `Sendable` conformance (thanks [@​rhysm94](https://github.com/rhysm94), [https://github.com/pointfreeco/swift-composable-architecture/pull/2997](https://github.com/pointfreeco/swift-composable-architecture/pull/2997)). - Updated: Bumped swift-custom-dump to avoid a crash and leverage the latest tools for shared state (thanks [@​y-mimura](https://github.com/y-mimura), [https://github.com/pointfreeco/swift-composable-architecture/pull/3008](https://github.com/pointfreeco/swift-composable-architecture/pull/3008)). - Infrastructure: Update README.md package addition wording to match latest Xcode (thanks [@​dafurman](https://github.com/dafurman), [https://github.com/pointfreeco/swift-composable-architecture/pull/2998](https://github.com/pointfreeco/swift-composable-architecture/pull/2998)). - Infrastructure: Tutorial fixes and updates (thanks [@​dafurman](https://github.com/dafurman), [https://github.com/pointfreeco/swift-composable-architecture/pull/3003](https://github.com/pointfreeco/swift-composable-architecture/pull/3003)). #### New Contributors - [@​dafurman](https://github.com/dafurman) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/2998](https://github.com/pointfreeco/swift-composable-architecture/pull/2998) - [@​y-mimura](https://github.com/y-mimura) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/3008](https://github.com/pointfreeco/swift-composable-architecture/pull/3008) **Full Changelog**: pointfreeco/swift-composable-architecture@1.9.3...1.10.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just went through the written tutorials - this is such a cool format for that style of teaching!
I found some typos and minor points where clarity could be added, so here's a PR for that!