Don't warn when dismissing two layers of tree nav #3037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, popping two layers in a nav tree will cause intermediate, invalid stores to send `dismiss` actions when they shouldn't. This branch avoids this by checking the store's validity before sending the action along. Fixes #3031.
mbrandonw
approved these changes
Apr 30, 2024
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
May 1, 2024
…ure to from: "1.10.2" (#1055) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [pointfreeco/swift-composable-architecture](https://github.com/pointfreeco/swift-composable-architecture) | patch | `from: "1.10.1"` -> `from: "1.10.2"` | --- ### Release Notes <details> <summary>pointfreeco/swift-composable-architecture (pointfreeco/swift-composable-architecture)</summary> ### [`v1.10.2`](https://github.com/pointfreeco/swift-composable-architecture/releases/tag/1.10.2) [Compare Source](https://github.com/pointfreeco/swift-composable-architecture/compare/1.10.1...1.10.2) #### What's Changed - Fixed: `@Shared(.appStorage)` initializer with explicit `= nil` should not crash ([https://github.com/pointfreeco/swift-composable-architecture/pull/3035](https://github.com/pointfreeco/swift-composable-architecture/pull/3035)). - Fixed: Don't warn when dismissing two layers of tree-based navigation ([https://github.com/pointfreeco/swift-composable-architecture/pull/3037](https://github.com/pointfreeco/swift-composable-architecture/pull/3037)). - Fixed: Don't emit perception warnings when deploying to 17.0.0 ([https://github.com/pointfreeco/swift-composable-architecture/pull/3036](https://github.com/pointfreeco/swift-composable-architecture/pull/3036)). - Infrastructure: Fix typo in Reducers article (thanks [@​larryonoff](https://github.com/larryonoff), [https://github.com/pointfreeco/swift-composable-architecture/pull/3034](https://github.com/pointfreeco/swift-composable-architecture/pull/3034)) #### New Contributors - [@​larryonoff](https://github.com/larryonoff) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/3034](https://github.com/pointfreeco/swift-composable-architecture/pull/3034) **Full Changelog**: pointfreeco/swift-composable-architecture@1.10.1...1.10.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, popping two layers in a nav tree will cause intermediate, invalid stores to send
dismissactions when they shouldn't. This branch avoids this by checking the store's validity before sending the action along.Fixes #3031.