Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all ActorIsolated to LockIsolated. #3198

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

mbrandonw
Copy link
Member

No description provided.

@mbrandonw mbrandonw requested a review from stephencelis June 21, 2024 14:22
@Alex293
Copy link
Contributor

Alex293 commented Jun 21, 2024

Can you briefly explain the reason behind this ?

will actorisolated be deprecated ?

@mbrandonw
Copy link
Member Author

Can you briefly explain the reason behind this ?

will actorisolated be deprecated ?

Yeah, we will be deprecating ActorIsolated in swift-concurrency-extras. It really just has no advanced over LockIsolated (as far as we can tell), yet it's less ergonomic to use.

Do you have an example of where it is better to use ActorIsolated over LockIsolated?

@stephencelis
Copy link
Member

@Alex293 For reference, here's the PR deprecating: pointfreeco/swift-concurrency-extras#29

@Alex293
Copy link
Contributor

Alex293 commented Jun 21, 2024

I don’t have any specific use case, I was just wondering why, thanks !

@mbrandonw mbrandonw merged commit 476050c into main Jun 21, 2024
7 checks passed
@mbrandonw mbrandonw deleted the convert-actor-to-lock-isolated branch June 21, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants