Improve UIKit case studies: ListsOfState #3220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junbangg
pushed a commit
to junbangg/swift-composable-architecture
that referenced
this pull request
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have improved the ListsOfState example.
The
tableView(_:cellForRowAt:)delegate method can be called multiple times for the same indexPath, and in the current code, theobserve(_:)method is executed multiple times for the same indexPath.When the
observe(_:)method is executed multiple times, the closure is called unnecessarily many times when the Counter model at the corresponding index is changed.To prevent this, I have added the observation cancellation logic.