Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import modules on NavigationStack tutorial source code. #3409

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

loinsir
Copy link
Contributor

@loinsir loinsir commented Sep 25, 2024

This PR adds import modules to the NavigationStacks tutorial's source code.

This may help with compiling the source code.

@loinsir loinsir changed the title Add Import modules on NavigationStack tutorial source codes. Add import modules on NavigationStack tutorial source codes. Sep 25, 2024
@loinsir loinsir changed the title Add import modules on NavigationStack tutorial source codes. Add import modules on NavigationStack tutorial source code. Sep 25, 2024
Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One small thing is that our style guide is to generally organize things alphabetically. Think you can update these imports to be alphabetical?

import SwiftUI
import ComposableArchitecture
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think you have time to alphabetize these? For example:

Suggested change
import SwiftUI
import ComposableArchitecture
import ComposableArchitecture
import SwiftUI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I changed these things. Please check my commit. Thanks.

@loinsir loinsir force-pushed the fix/tutorial-import-library branch from c14a8dd to 658e608 Compare September 26, 2024 00:44
Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephencelis stephencelis merged commit c8c97a4 into pointfreeco:main Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants