-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conform to ExpressibleByArrayLiteral
and ExpressibleByDictionaryLiteral
#49
Conform to ExpressibleByArrayLiteral
and ExpressibleByDictionaryLiteral
#49
Conversation
@fwcd Check out how we implemented it in swift-tagged: https://github.com/pointfreeco/swift-tagged/blob/f3f773a5e13f3c8f0ab1ce2ae6378058acefa87d/Sources/Tagged/Tagged.swift#L289-L314 I think you could do similar here to conditionally support any underlying collection that conforms to the |
That's a neat workaround to the issue that Swift doesn't have a spread operator yet and definitely the simpler solution. Unfortunately, there is another issue, certain overloads now become ambigous with
|
Hm! Could you try adding a |
That did the trick, thanks! The test suite now passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for taking the time to contribute 😄
Fixes #48
This branch adds experimental support for the aforementioned protocols.